trading
/
PTMagic
mirror of https://github.com/PTMagicians/PTMagic.git
2
0
Fork 0
Code Issues Releases Wiki Activity

Fix cleanup of streams for http calls

This commit is contained in:
djbadders 2019-09-06 23:55:41 +01:00
parent 0c4f111468
commit da511f2edd
1 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
Core/MarketAnalyzer/BaseAnalyzer.cs
View File

@ -29,14 +29,17 @@ namespace Core.MarketAnalyzer
request.Timeout = 60000; request.Timeout = 60000;
HttpWebResponse httpResponse = null; HttpWebResponse httpResponse = null;
string jsonString = string.Empty;
try try
{ {
httpResponse = (HttpWebResponse)request.GetResponse(); httpResponse = (HttpWebResponse)request.GetResponse();
StreamReader jsonReader = new StreamReader(httpResponse.GetResponseStream()); using (StreamReader jsonReader = new StreamReader(httpResponse.GetResponseStream()))
string jsonString = jsonReader.ReadToEnd(); {
jsonReader.Close(); jsonString = jsonReader.ReadToEnd();
jsonReader.Close();
}
jsonObject = JsonConvert.DeserializeObject<Dictionary<string, dynamic>>(jsonString); jsonObject = JsonConvert.DeserializeObject<Dictionary<string, dynamic>>(jsonString);
@ -44,6 +47,7 @@ namespace Core.MarketAnalyzer
} }
catch (WebException ex) catch (WebException ex)
{ {
log.DoLogCritical(string.Format("Error whilst calling {0} \nError: {1}", url, ex.Message), ex);
// Error calling the service but we got a response so dump it. // Error calling the service but we got a response so dump it.
string responseString = string.Empty; string responseString = string.Empty;
var encoding = httpResponse.CharacterSet == "" ? Encoding.UTF8 : Encoding.GetEncoding(httpResponse.CharacterSet); var encoding = httpResponse.CharacterSet == "" ? Encoding.UTF8 : Encoding.GetEncoding(httpResponse.CharacterSet);