Changed logging behaviour for GitHub version checks

This commit is contained in:
Legedric 2018-05-23 16:07:46 +02:00
parent 812498667c
commit ca3ede11b3
1 changed files with 6 additions and 5 deletions

View File

@ -38,7 +38,7 @@ namespace Core.MarketAnalyzer {
return jsonObject; return jsonObject;
} }
public static Newtonsoft.Json.Linq.JObject GetSimpleJsonObjectFromURL(string url, LogHelper log, bool onlyLogDebug) { public static Newtonsoft.Json.Linq.JObject GetSimpleJsonObjectFromURL(string url, LogHelper log, bool swallowException) {
Newtonsoft.Json.Linq.JObject jsonObject = null; Newtonsoft.Json.Linq.JObject jsonObject = null;
HttpWebRequest request = (HttpWebRequest)WebRequest.Create(url); HttpWebRequest request = (HttpWebRequest)WebRequest.Create(url);
@ -59,10 +59,11 @@ namespace Core.MarketAnalyzer {
log.DoLogCritical(ex.Message, ex); log.DoLogCritical(ex.Message, ex);
throw ex; throw ex;
} catch (Exception ex) { } catch (Exception ex) {
if (onlyLogDebug) { if (swallowException) {
log.DoLogDebug("Url: " + url + " Message: " + ex.Message); // Do nothing, as we do not want to get this logged. Only uncritical functions uses this
} else { } else {
log.DoLogCritical(ex.Message, ex); log.DoLogCritical("Url: " + url + " Message: " + ex.Message, ex);
throw ex;
} }
} }
@ -152,7 +153,7 @@ namespace Core.MarketAnalyzer {
string baseUrl = "http://free.currencyconverterapi.com/api/v5/convert?q=USD_" + currency + "&compact=y"; string baseUrl = "http://free.currencyconverterapi.com/api/v5/convert?q=USD_" + currency + "&compact=y";
log.DoLogDebug("http://free.currencyconverterapi.com - Getting latest exchange rates..."); log.DoLogDebug("http://free.currencyconverterapi.com - Getting latest exchange rates...");
Newtonsoft.Json.Linq.JObject jsonObject = GetSimpleJsonObjectFromURL(baseUrl, log, true); Newtonsoft.Json.Linq.JObject jsonObject = GetSimpleJsonObjectFromURL(baseUrl, log, false);
if (jsonObject != null) { if (jsonObject != null) {
log.DoLogDebug("http://free.currencyconverterapi.com - Received latest exchange rates."); log.DoLogDebug("http://free.currencyconverterapi.com - Received latest exchange rates.");