From b0c1406cf919dede5b5e4597a75a5bf710f4617f Mon Sep 17 00:00:00 2001 From: Alan Orth Date: Tue, 15 Nov 2016 15:37:26 +0200 Subject: [PATCH] Remove references to Cache-Control public A previous commit removed some, but missed these. Where a location directive was using Expires to set a future expiry in conjunction with Cache-Control public, I have replaced the time with an equal max-age. Furthermore, Google's web performance guide says that "public" is implicit if there is a max-age specified. See: https://developers.google.com/web/fundamentals/performance/optimizing-content-efficiency/http-caching --- doc/common-problems.md | 2 -- h5bp/location/cross-domain-fonts.conf | 3 +-- h5bp/location/expires.conf | 3 +-- 3 files changed, 2 insertions(+), 6 deletions(-) diff --git a/doc/common-problems.md b/doc/common-problems.md index 8a06c31..20fa4f5 100644 --- a/doc/common-problems.md +++ b/doc/common-problems.md @@ -148,7 +148,6 @@ will be a 404. The reason for this is that H5bp's basic ruleset includes, for ex location ~* \.(?:jpg|jpeg|gif|png|ico|cur|gz|svg|svgz|mp4|ogg|ogv|webm|htc)$ { expires 1M; access_log off; - add_header Cache-Control "public"; } Which will _also_ capture any dynamic requests matching that url pattern and not @@ -166,7 +165,6 @@ Modifying (all) location blocks as follows: expires 1M; access_log off; - add_header Cache-Control "public"; } Will make Nginx pass requests for files that don't exist to the application. diff --git a/h5bp/location/cross-domain-fonts.conf b/h5bp/location/cross-domain-fonts.conf index b55ee6b..e0fa318 100644 --- a/h5bp/location/cross-domain-fonts.conf +++ b/h5bp/location/cross-domain-fonts.conf @@ -7,7 +7,6 @@ location ~* \.(?:ttf|ttc|otf|eot|woff|woff2)$ { # See http://wiki.nginx.org/HttpCoreModule#location # And https://github.com/h5bp/server-configs/issues/85 # And https://github.com/h5bp/server-configs/issues/86 - expires 1M; access_log off; - add_header Cache-Control "public"; + add_header Cache-Control "max-age=2592000"; } diff --git a/h5bp/location/expires.conf b/h5bp/location/expires.conf index a1be73e..459dfd2 100644 --- a/h5bp/location/expires.conf +++ b/h5bp/location/expires.conf @@ -20,9 +20,8 @@ location ~* \.(?:rss|atom)$ { # Media: images, icons, video, audio, HTC location ~* \.(?:jpg|jpeg|gif|png|ico|cur|gz|svg|svgz|mp4|ogg|ogv|webm|htc)$ { - expires 1M; access_log off; - add_header Cache-Control "public"; + add_header Cache-Control "max-age=2592000"; } # CSS and Javascript