gaja-group
/
matrix-bot
2
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Merge pull request #7518 from vector-im/dbkr/better_fix_for_windows_crashes 

Don't set tags on notifications
This commit is contained in:
David Baker 2018-10-18 19:26:08 +01:00 committed by GitHub
parent 47493fa7d9 2854c0969b
commit c1dfbd6993
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 0 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/vector/platform/ElectronPlatform.js
View File

@ -143,7 +143,6 @@ export default class ElectronPlatform extends VectorBasePlatform {
{ {
body: msg, body: msg,
icon: avatarUrl, icon: avatarUrl,
tag: 'vector',
silent: true, // we play our own sounds silent: true, // we play our own sounds
}, },
); );
@ -169,11 +168,6 @@ export default class ElectronPlatform extends VectorBasePlatform {
} }
clearNotification(notif: Notification) { clearNotification(notif: Notification) {
// This crashes on windows under certain circumstances: can't find any
// workaround other than not closing notifs.
// https://github.com/electron/electron/issues/15251
// https://github.com/vector-im/riot-web/issues/7512
if (window.process.platform === 'win32') return;
notif.close(); notif.close();
} }