From 420537a64d1b99eae69a6c37a1897c4e09ce1b8e Mon Sep 17 00:00:00 2001
From: "J. Ryan Stinnett" <jryans@gmail.com>
Date: Tue, 25 Feb 2020 11:44:33 +0000
Subject: [PATCH 1/2] Relax macOS notarisation check to print a warning
This makes it a bit more friendly to build macOS Electron builds without a
notarisation config set up by only warning when it is missing.
---
scripts/electron_afterSign.js | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/scripts/electron_afterSign.js b/scripts/electron_afterSign.js
index 5952976a..5e5850b0 100644
--- a/scripts/electron_afterSign.js
+++ b/scripts/electron_afterSign.js
@@ -10,7 +10,10 @@ exports.default = async function(context) {
// from the keychain, so we need to get it from the environment.
const userId = process.env.NOTARIZE_APPLE_ID;
if (userId === undefined) {
- throw new Error("User ID not found. Set NOTARIZE_APPLE_ID.");
+ console.warn(
+ "Skipping notarisation: User ID not found, set NOTARIZE_APPLE_ID.",
+ );
+ return;
}
console.log("Notarising macOS app. This may be some time.");
From bdb395aa416b8bd415c9c1aed69eaa1d9412eb2b Mon Sep 17 00:00:00 2001
From: "J. Ryan Stinnett" <jryans@gmail.com>
Date: Tue, 25 Feb 2020 12:05:36 +0000
Subject: [PATCH 2/2] Change to banner style
---
scripts/electron_afterSign.js | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/scripts/electron_afterSign.js b/scripts/electron_afterSign.js
index 5e5850b0..e98ebde6 100644
--- a/scripts/electron_afterSign.js
+++ b/scripts/electron_afterSign.js
@@ -11,7 +11,9 @@ exports.default = async function(context) {
const userId = process.env.NOTARIZE_APPLE_ID;
if (userId === undefined) {
console.warn(
- "Skipping notarisation: User ID not found, set NOTARIZE_APPLE_ID.",
+ "!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!\n" +
+ "! Skipping notarisation: User ID not found, set NOTARIZE_APPLE_ID. !\n" +
+ "!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!",
);
return;
}