From cde5c9c027c92a6ca3a8d9135586115cd44d5fab Mon Sep 17 00:00:00 2001 From: RiotRobot Date: Wed, 27 Nov 2019 12:15:05 +0000 Subject: [PATCH] Remove redundant Windows installer signing The signing in `electron-package.sh` is no longer needed, since it's already handled in the new sign script for `electron-builder`. --- scripts/electron-package.sh | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/scripts/electron-package.sh b/scripts/electron-package.sh index 7a8a5ca7..9a0566ae 100755 --- a/scripts/electron-package.sh +++ b/scripts/electron-package.sh @@ -165,20 +165,6 @@ cp $distdir/squirrel-windows/RELEASES "$pubdir/update/win32/x64/" # longer appears to work). cp $distdir/*_amd64.deb "$projdir/electron_app/dist/" -# Now we sign the windows installer executables (as opposed to the main binary which -# is signed in the electron afteSign hook) -echo "Signing Windows installers..." - -exe32=( "$distdir"/squirrel-windows-ia32/*.exe ) -basename32=`basename "$exe32"` -osslsigncode sign $OSSLSIGNCODE_SIGNARGS -pass "$token_password" -in "$exe32" -out "$projdir/electron_app/pub/install/win32/ia32/$basename32" - -exe64=( "$distdir"/squirrel-windows/*.exe ) -basename64=`basename "$exe64"` -osslsigncode sign $OSSLSIGNCODE_SIGNARGS -pass "$token_password" -in "$exe64" -out "$projdir/electron_app/pub/install/win32/x64/$basename64" - -echo "Installers signed" - rm -rf "$builddir" echo "$pubdir can now be hosted on your web server."