From 5356eab1593b0d9c01b526860bdcff9db1b59ad9 Mon Sep 17 00:00:00 2001 From: David Baker Date: Fri, 26 May 2017 13:16:36 +0100 Subject: [PATCH] Correct docs Change array.push guideline to not using _t at class-load time which was probably the actual problem. Update guidelines to include punctuation. --- docs/translating-dev.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/translating-dev.md b/docs/translating-dev.md index 8bebd0bc..80d4b64a 100644 --- a/docs/translating-dev.md +++ b/docs/translating-dev.md @@ -22,5 +22,5 @@ ## Things to know/Style Guides - Do not use it inside ``getDefaultProps`` at the point where ``getDefaultProps`` is initialized the translations aren't loaded yet and it causes missing translations. -- Do use ``Array.push()`` instead of directly defining it inside the array. Arrays are not able to access ``_t()`` at runtime. -- Do not include full stops, Emoji or similiar miscellaneous Things to the strings. They are not required to be translated. +- If using translated strings as constants, translated strings can't be in constants loaded at class-load time since the translations won't be loaded. +- If a string is presented in the UI with punctuation like a full stop, include this in the translation strings, since punctuation varies between languages too.