From 96393f69b6a5aa832a6591d77048d62e02629c2c Mon Sep 17 00:00:00 2001 From: David Baker Date: Fri, 26 May 2017 22:37:44 +0100 Subject: [PATCH 1/5] Remove old versions before linking react/js sdk --- scripts/fetch-develop.deps.sh | 2 ++ 1 file changed, 2 insertions(+) diff --git a/scripts/fetch-develop.deps.sh b/scripts/fetch-develop.deps.sh index c3bfb4e1..bbbc8341 100755 --- a/scripts/fetch-develop.deps.sh +++ b/scripts/fetch-develop.deps.sh @@ -40,11 +40,13 @@ dodep matrix-org matrix-react-sdk mkdir -p node_modules cd node_modules +rm -r matrix-js-sdk 2> /dev/null ln -s ../matrix-js-sdk ./ pushd matrix-js-sdk npm install popd +rm -r matrix-react-sdk 2> /dev/null ln -s ../matrix-react-sdk ./ pushd matrix-react-sdk mkdir -p node_modules From 35a671d43c53760698a6131b38c6628e2799dbe9 Mon Sep 17 00:00:00 2001 From: Matthew Hodgson Date: Fri, 26 May 2017 22:45:14 +0100 Subject: [PATCH 2/5] more i18n instructions --- docs/translating.md | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/docs/translating.md b/docs/translating.md index cd8dd4f6..ca9920d3 100644 --- a/docs/translating.md +++ b/docs/translating.md @@ -6,6 +6,11 @@ - Be able to understand English - Be able to understand the language you want to translate riot-web into +## Step 0: Join #riotweb-translations:matrix.org + +1. Come and join https://riot.im/develop/#/room/#riotweb-translations:matrix.org +2. Read scrollback and/or ask if anyone else is working on your language, and co-ordinate if needed. In general little-or-no coordination is needed though :) + ## Step 1: Preparing your Weblate Profile 1. Head to https://translate.nordgedanken.de and register either via Github or email @@ -45,12 +50,15 @@ The yellow button has to be used if you are unsure about the translation but you ### What are "%(something)s"? -These things are variables that are filled inside the code. They can be room names, usernames or similiar. If you find one use it for changing the word order but do not delete it as thing are missing if you do so. +These things are variables that are expanded when displayed by Riot. They can be room names, usernames or similar. If you find one, you can move to the right place for your language, but not delete it as the variable will be missing if you do. + +A special case is `%(urlStart)s` and `%(urlEnd)s` which are used to mark the beginning of a hyperlink (i.e. `` and ``. You must keep these markers surrounding the equivalent string in your language that needs to be hyperlinked. ### "I want to come back to this string. How?" You can use inside the translation field "Review needed" checkbox. It will be shown as Strings that need to be reviewed. + ### Further reading -The official Doc provides some more in-deepth explanation on how to do translations and talks about do and don't's. You can find it at: https://docs.weblate.org/en/latest/user/translating.html +The official Weblate doc provides some more in-deepth explanation on how to do translations and talks about do and don'ts. You can find it at: https://docs.weblate.org/en/latest/user/translating.html From 22e5e2126b823a615a4a0355cad00e52ebe3480e Mon Sep 17 00:00:00 2001 From: David Baker Date: Fri, 26 May 2017 22:51:55 +0100 Subject: [PATCH 3/5] rev-parse the commit from the deps Because it's not added to package.json by npm anymore --- scripts/jenkins.sh | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/scripts/jenkins.sh b/scripts/jenkins.sh index 17f86fe1..4f2e9405 100755 --- a/scripts/jenkins.sh +++ b/scripts/jenkins.sh @@ -34,11 +34,9 @@ npm run lintall -- -f checkstyle -o eslint.xml || true rm dist/riot-*.tar.gz || true # rm previous artifacts without failing if it doesn't exist - # node_modules deps from 'npm install' don't have a .git dir so can't - # rev-parse; but they do set the commit in package.json under 'gitHead' which - # we're grabbing here. -REACT_SHA=$(grep 'gitHead' node_modules/matrix-react-sdk/package.json | cut -d \" -f 4 | head -c 12) -JSSDK_SHA=$(grep 'gitHead' node_modules/matrix-js-sdk/package.json | cut -d \" -f 4 | head -c 12) +# Since the deps are fetched from git, we can rev-parse +REACT_SHA=$(cd node_modules/matrix-react-sdk; git rev-parse --short=12 HEAD) +JSSDK_SHA=$(cd node_modules/matrix-js-sdk; git rev-parse --short=12 HEAD) VECTOR_SHA=$(git rev-parse --short=12 HEAD) # use the ACTUAL SHA rather than assume develop From d0395b939a213b9bd1a8dbd0770c4d1741fd0158 Mon Sep 17 00:00:00 2001 From: David Baker Date: Fri, 26 May 2017 22:59:40 +0100 Subject: [PATCH 4/5] Add babel eslint plugin As our linter has been failing because it needs it --- package.json | 1 + 1 file changed, 1 insertion(+) diff --git a/package.json b/package.json index 0f0ffe36..29b5beee 100644 --- a/package.json +++ b/package.json @@ -104,6 +104,7 @@ "emojione": "^2.2.7", "eslint": "^3.14.0", "eslint-config-google": "^0.7.1", + "eslint-plugin-babel": "^4.1.1", "eslint-plugin-flowtype": "^2.30.0", "eslint-plugin-react": "^6.9.0", "expect": "^1.16.0", From 1ff6d4846c840b66aa1247a40b80cf45d9d484b5 Mon Sep 17 00:00:00 2001 From: Matthew Hodgson Date: Sat, 27 May 2017 00:13:59 +0100 Subject: [PATCH 5/5] css for alwaysShowTimestamps --- .../vector/css/matrix-react-sdk/views/rooms/_EventTile.scss | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/skins/vector/css/matrix-react-sdk/views/rooms/_EventTile.scss b/src/skins/vector/css/matrix-react-sdk/views/rooms/_EventTile.scss index 2dd037eb..9d970ad4 100644 --- a/src/skins/vector/css/matrix-react-sdk/views/rooms/_EventTile.scss +++ b/src/skins/vector/css/matrix-react-sdk/views/rooms/_EventTile.scss @@ -183,6 +183,10 @@ limitations under the License. visibility: visible; } +.mx_MessagePanel_alwaysShowTimestamps .mx_MessageTimestamp { + visibility: visible; +} + .mx_EventTile_selected .mx_MessageTimestamp { left: 3px; }